Skip to content

test_runner: match minimum file column to 'all files' #57848

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 14, 2025
Merged

test_runner: match minimum file column to 'all files' #57848

merged 1 commit into from
Apr 14, 2025
+42 −3

Conversation

@islandryu
Copy link
Member

Fixed a problem that all files are omitted when the file name displayed in coverage is too short.

ℹ tests 1
ℹ suites 0
ℹ pass 1
ℹ fail 0
ℹ cancelled 0
ℹ skipped 0
ℹ todo 0
ℹ duration_ms 3.993167
ℹ start of coverage report
ℹ ------------------------------------------------------------------------------------
ℹ file   | line % | branch % | funcs % | uncovered lines
ℹ ------------------------------------------------------------------------------------
ℹ a.js   |  55.77 |   100.00 |    0.00 | 5-7 9-11 13-15 17-19 29-30 40-42 45-47 50-52
ℹ ------------------------------------------------------------------------------------
ℹ …files |  55.77 |   100.00 |    0.00 | 
ℹ ------------------------------------------------------------------------------------
ℹ end of coverage report

@nodejs-github-bot
Copy link
Collaborator

Review requested:

  • @nodejs/test_runner

@nodejs-github-bot nodejs-github-bot added needs-ci PRs that need a full CI run. test_runner Issues and PRs related to the test runner subsystem. labels Apr 12, 2025
@codecov
Copy link

codecov bot commented Apr 12, 2025 •
edited
Loading

Codecov Report

Attention: Patch coverage is 0% with 1 line in your changes missing coverage. Please review.

Project coverage is 90.24%. Comparing base (86f86a2) to head (697228d).
Report is 18 commits behind head on main.

Files with missing lines Patch % Lines
lib/internal/test_runner/utils.js 0.00% 1 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main   #57848      +/-   ##
==========================================
+ Coverage   90.22%   90.24%   +0.01%     
==========================================
  Files         630      630              
  Lines      185481   185481              
  Branches    36364    36369       +5     
==========================================
+ Hits       167357   167386      +29     
+ Misses      11004    11000       -4     
+ Partials     7120     7095      -25
Files with missing lines Coverage Δ
lib/internal/test_runner/utils.js 58.52% <0.00%> (ø)

... and 24 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

pmarchini
pmarchini approved these changes Apr 13, 2025
View reviewed changes
Copy link
Member

@pmarchini pmarchini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution!!!
LGTM!

@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/66238/

@pmarchini pmarchini added author ready PRs that have at least one approval, no pending requests for changes, and a CI started. request-ci Add this label to start a Jenkins CI on a PR. commit-queue Add this label to land a pull request using GitHub Actions. and removed request-ci Add this label to start a Jenkins CI on a PR. labels Apr 13, 2025
@nodejs-github-bot nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Apr 14, 2025
@nodejs-github-bot nodejs-github-bot merged commit f89baf2 into nodejs:main Apr 14, 2025
72 checks passed
@nodejs-github-bot
Copy link
Collaborator

Landed in f89baf2

RafaelGSS pushed a commit that referenced this pull request May 1, 2025
@islandryu @RafaelGSS
test_runner: match minimum file column to 'all files'
b4908e3 
PR-URL: #57848
Reviewed-By: Pietro Marchini <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Jake Yuesong Li <[email protected]>
@RafaelGSS RafaelGSS mentioned this pull request May 1, 2025
Merged
RafaelGSS pushed a commit that referenced this pull request May 2, 2025
@islandryu @RafaelGSS
test_runner: match minimum file column to 'all files'
7416a7f 
PR-URL: #57848
Reviewed-By: Pietro Marchini <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Jake Yuesong Li <[email protected]>
aduh95 pushed a commit that referenced this pull request May 6, 2025
@islandryu @aduh95
test_runner: match minimum file column to 'all files'
6025917 
PR-URL: #57848
Reviewed-By: Pietro Marchini <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Jake Yuesong Li <[email protected]>
aduh95 pushed a commit that referenced this pull request May 6, 2025
@islandryu @aduh95
test_runner: match minimum file column to 'all files'
5ef665f 
PR-URL: #57848
Reviewed-By: Pietro Marchini <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Jake Yuesong Li <[email protected]>
RafaelGSS pushed a commit that referenced this pull request May 14, 2025
@islandryu @RafaelGSS
test_runner: match minimum file column to 'all files'
0a61b78 
PR-URL: #57848
Reviewed-By: Pietro Marchini <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Jake Yuesong Li <[email protected]>
aduh95 pushed a commit that referenced this pull request May 16, 2025
@islandryu @aduh95
test_runner: match minimum file column to 'all files'
abdaa33 
PR-URL: #57848
Reviewed-By: Pietro Marchini <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Jake Yuesong Li <[email protected]>
aduh95 pushed a commit that referenced this pull request May 17, 2025
@islandryu @aduh95
test_runner: match minimum file column to 'all files'
4eaf899 
PR-URL: #57848
Reviewed-By: Pietro Marchini <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Jake Yuesong Li <[email protected]>
aduh95 pushed a commit that referenced this pull request May 17, 2025
@islandryu @aduh95
test_runner: match minimum file column to 'all files'
7a1a979 
PR-URL: #57848
Reviewed-By: Pietro Marchini <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Jake Yuesong Li <[email protected]>
aduh95 pushed a commit that referenced this pull request May 17, 2025
@islandryu @aduh95
test_runner: match minimum file column to 'all files'
cf58fa5 
PR-URL: #57848
Reviewed-By: Pietro Marchini <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Jake Yuesong Li <[email protected]>
aduh95 pushed a commit that referenced this pull request May 18, 2025
@islandryu @aduh95
test_runner: match minimum file column to 'all files'
b0097db 
PR-URL: #57848
Reviewed-By: Pietro Marchini <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Jake Yuesong Li <[email protected]>
@github-actions github-actions bot mentioned this pull request May 19, 2025
Merged
aduh95 pushed a commit that referenced this pull request May 19, 2025
@islandryu @aduh95
test_runner: match minimum file column to 'all files'
edb7dd1 
PR-URL: #57848
Reviewed-By: Pietro Marchini <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Jake Yuesong Li <[email protected]>
@ghost ghost mentioned this pull request Jun 8, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@cjihrig cjihrig cjihrig approved these changes

@jakecastelli jakecastelli jakecastelli approved these changes

@pmarchini pmarchini pmarchini approved these changes

Assignees

No one assigned

Labels

author ready PRs that have at least one approval, no pending requests for changes, and a CI started. needs-ci PRs that need a full CI run. test_runner Issues and PRs related to the test runner subsystem.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@islandryu @nodejs-github-bot @cjihrig @jakecastelli @pmarchini